Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeteroData: data.*_dict fix in case attribute does not exist #3897

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Jan 20, 2022

No description provided.

@rusty1s rusty1s added the bug label Jan 20, 2022
@rusty1s rusty1s self-assigned this Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #3897 (2b09ff9) into master (3108d10) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3897      +/-   ##
==========================================
- Coverage   81.68%   81.66%   -0.02%     
==========================================
  Files         299      299              
  Lines       15208    15207       -1     
==========================================
- Hits        12422    12419       -3     
- Misses       2786     2788       +2     
Impacted Files Coverage Δ
torch_geometric/data/hetero_data.py 92.71% <100.00%> (-0.03%) ⬇️
torch_geometric/transforms/gdc.py 77.94% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3108d10...2b09ff9. Read the comment docs.

@rusty1s rusty1s merged commit 052ce24 into master Jan 20, 2022
@rusty1s rusty1s deleted the pyg_hetero_dict_fix branch January 20, 2022 09:34
Copy link
Contributor

@RexYing RexYing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for helping to fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants