Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to TemporalData #3988

Merged
merged 6 commits into from
Mar 10, 2022
Merged

Conversation

otaviocx
Copy link
Contributor

@otaviocx otaviocx commented Feb 2, 2022

What

Add tests for torch_geometric.data.TemporalData.

Why

To improve the tests coverage and to ensure the temporal module is working as expected.

Testing

To execute the added tests, someone can run pytest test/data/test_temporal.py

@otaviocx otaviocx changed the title Add tests to TemporalData [WIP] Add tests to TemporalData Feb 3, 2022
@rusty1s rusty1s marked this pull request as draft February 4, 2022 14:21
@rusty1s
Copy link
Member

rusty1s commented Mar 7, 2022

Let me know once you want me to take a closer look onto this :)

@otaviocx otaviocx marked this pull request as ready for review March 10, 2022 11:02
@otaviocx
Copy link
Contributor Author

Hi @rusty1s, it is ready for review.

@rusty1s rusty1s changed the title [WIP] Add tests to TemporalData Add tests to TemporalData Mar 10, 2022
@rusty1s rusty1s self-requested a review March 10, 2022 15:35
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Thanks a lot!

@rusty1s rusty1s merged commit f4443f1 into pyg-team:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants