Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Laplacian computation #4187

Merged
merged 17 commits into from
Mar 11, 2022
Merged

Mesh Laplacian computation #4187

merged 17 commits into from
Mar 11, 2022

Conversation

daniel-unyi-42
Copy link
Contributor

Mesh Laplacian computation in pure PyTorch.

I'm planning to add another test case (some simple shape) and the formula in the documentation.

@daniel-unyi-42
Copy link
Contributor Author

daniel-unyi-42 commented Mar 3, 2022 •
edited

Added another test and the formula in the documentation.
But the formula isn't rendered correctly,
could you help me with that?

rusty1s
rusty1s reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for your contributions. Left some comments.

.pytest_cache/v/cache/lastfailed Outdated Show resolved Hide resolved
torch_geometric/utils/get_mesh_laplacian.py Outdated Show resolved Hide resolved
torch_geometric/utils/get_mesh_laplacian.py Outdated Show resolved Hide resolved
torch_geometric/utils/get_mesh_laplacian.py Outdated Show resolved Hide resolved
torch_geometric/utils/get_mesh_laplacian.py Outdated Show resolved Hide resolved
torch_geometric/utils/get_mesh_laplacian.py Outdated Show resolved Hide resolved
torch_geometric/utils/get_mesh_laplacian.py Outdated Show resolved Hide resolved
@daniel-unyi-42
Copy link
Contributor Author

daniel-unyi-42 commented Mar 7, 2022 •
edited

Finished up everything.
Formula is rendering correctly.
I think it's ready to merge, if you don't have any more suggestions.

rusty1s
rusty1s approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you :)

@rusty1s rusty1s merged commit 4231111 into pyg-team:master Mar 11, 2022
@xieweiyi
Copy link

The summation row-wise for the computed laplacian is not zero.

@xieweiyi xieweiyi mentioned this pull request Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@daniel-unyi-42 daniel-unyi-42

Labels
0 - Priority P0 feature help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniel-unyi-42 @xieweiyi @rusty1s