Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple aggregations in SAGEConv #5033

Merged
merged 13 commits into from
Jul 27, 2022
Merged

Conversation

lightaime
Copy link
Contributor

@lightaime lightaime commented Jul 22, 2022

This PR supports auto-infer the number of channels for multiple aggregations in SAGEConv.

Addresses item #5009 in #4712.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #5033 (d4ea1d0) into master (333d3d3) will decrease coverage by 1.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5033      +/-   ##
==========================================
- Coverage   84.85%   82.97%   -1.88%     
==========================================
  Files         332      332              
  Lines       18292    18300       +8     
==========================================
- Hits        15521    15184     -337     
- Misses       2771     3116     +345     
Impacted Files Coverage Δ
torch_geometric/nn/aggr/multi.py 100.00% <100.00%> (+1.61%) ⬆️
torch_geometric/nn/conv/sage_conv.py 96.77% <100.00%> (+0.34%) ⬆️
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/profile/profile.py 32.94% <0.00%> (-15.30%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/nn/resolver.py 88.00% <0.00%> (-6.00%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/io/tu.py 93.90% <0.00%> (-2.44%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

torch_geometric/nn/conv/sage_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/sage_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/sage_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/sage_conv.py Outdated Show resolved Hide resolved
@lightaime lightaime requested a review from rusty1s July 26, 2022 12:56
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Thank you!

torch_geometric/nn/aggr/multi.py Outdated Show resolved Hide resolved
torch_geometric/nn/aggr/multi.py Outdated Show resolved Hide resolved
lightaime and others added 3 commits July 27, 2022 15:05
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@lightaime lightaime merged commit 23a7be0 into master Jul 27, 2022
@lightaime lightaime deleted the sageconv_multi_aggr branch July 27, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants