Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default splits to MalNetTiny dataset #5078

Closed
wants to merge 8 commits into from
Closed

Add default splits to MalNetTiny dataset #5078

wants to merge 8 commits into from

Conversation

flandolfi
Copy link
Contributor

Hi,

I modified the MalNetTiny so that it now downloads also the official split information given by the authors. I also removed a previously added remove_isolated_nodes() from the process (added in #3592), that I believe it should be done as a transform/pre-transform (with RemoveIsolatedNodes), if needed by the user. This may be reverted, if you think otherwise!

The code now add the graphs not in alphabetical order, but in the order defined by the split files. One should be able to easily extend the MalNetTiny class to the full dataset MalNet just by modifying self.data_url, self.split_url, self.raw_file_names() and self.download(). I could not try it since I do not have enough space at the moment (the full data is about 130GB).

Francesco

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #5078 (dd6db41) into master (a8f7a24) will decrease coverage by 1.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5078      +/-   ##
==========================================
- Coverage   84.88%   82.98%   -1.90%     
==========================================
  Files         333      333              
  Lines       18375    18371       -4     
==========================================
- Hits        15598    15246     -352     
- Misses       2777     3125     +348     
Impacted Files Coverage Δ
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/profile/profile.py 32.94% <0.00%> (-15.30%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/nn/resolver.py 88.00% <0.00%> (-6.00%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/io/tu.py 93.90% <0.00%> (-2.44%) ⬇️
torch_geometric/transforms/virtual_node.py 97.56% <0.00%> (-2.44%) ⬇️
torch_geometric/nn/models/basic_gnn.py 89.71% <0.00%> (-1.72%) ⬇️
... and 8 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@Padarn Padarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@rusty1s rusty1s changed the title Add default splits to MalNetTiny dataset Add default splits to MalNetTiny dataset Jul 30, 2022
@flandolfi flandolfi deleted the branch pyg-team:master September 14, 2022 10:31
@flandolfi flandolfi closed this Sep 14, 2022
@flandolfi flandolfi deleted the master branch September 14, 2022 10:31
@flandolfi flandolfi restored the master branch September 14, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants