Replace torch.nn.ModuleDict with custom ModuleDict
#5227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…rch_geometric into custom_module_dict
yaoyaowd
reviewed
Aug 18, 2022
rusty1s
reviewed
Aug 18, 2022
|
@yaoyaowd I believe PyTorch provides nested module access via dot-syntax in |
|
Tests failure does not seem related to this PR. I will look into this separately. |
|
@yaoyaowd As per pytorch/pytorch#6639 - seems like |
mananshah99
approved these changes
Aug 18, 2022
for more information, see https://pre-commit.ci
…rch_geometric into custom_module_dict
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #5227 +/- ##
==========================================
+ Coverage 83.09% 83.13% +0.03%
==========================================
Files 335 336 +1
Lines 18496 18521 +25
==========================================
+ Hits 15369 15397 +28
+ Misses 3127 3124 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
changed the title
torch.nn.ModuleDict with CustomModuleDicttorch.nn.ModuleDict with custom ModuleDict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch.nn.ModuleDictdoesn't allow.to be used in the keys. This prevents using node types with.in the name.CustomModuleDictwill support it by converting the.to#in the internal representation and converts it back to.in the external representation.