Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PNAConv: Customize activation function #5262

Merged
merged 5 commits into from Aug 23, 2022
Merged

PNAConv: Customize activation function #5262

merged 5 commits into from Aug 23, 2022

Conversation

pgniewko
Copy link
Contributor

Resolving: #5234

@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited

Codecov Report

Merging #5262 (ec1e81d) into master (65715da) will increase coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head ec1e81d differs from pull request most recent head 7daf22e. Consider uploading reports for the commit 7daf22e to get more accurate results

@@           Coverage Diff           @@
##           master    #5262   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         337      337           
  Lines       18576    18576           
=======================================
+ Hits        15446    15447    +1     
+ Misses       3130     3129    -1
Impacted Files Coverage Δ
torch_geometric/nn/conv/pna_conv.py 92.85% <75.00%> (+0.17%) ⬆️
torch_geometric/nn/models/basic_gnn.py 89.71% <0.00%> (+0.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title PNA custom activation function PNAConv: Customize activation function Aug 23, 2022
rusty1s
rusty1s approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rusty1s rusty1s enabled auto-merge (squash) August 23, 2022 09:42
@rusty1s rusty1s linked an issue Aug 23, 2022 that may be closed by this pull request
Activation function as a parameter in PNAConv #5234
Closed
@rusty1s rusty1s merged commit 8bcc77c into pyg-team:master Aug 23, 2022
@pgniewko pgniewko deleted the pawel/pna_act branch November 24, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@pgniewko pgniewko

Labels
0 - Priority P0 feature nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activation function as a parameter in PNAConv
2 participants
@pgniewko @rusty1s