Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(loader): check node types independently in remote_backend_utils #5318

Merged
merged 6 commits into from
Aug 31, 2022

Conversation

mananshah99
Copy link
Contributor

@mananshah99 mananshah99 commented Aug 31, 2022

Updates num_nodes in remote_backend_utils to support obtaining sizes of edges without hitting the feature store.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #5318 (872b746) into master (be471ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5318   +/-   ##
=======================================
  Coverage   83.36%   83.37%           
=======================================
  Files         338      338           
  Lines       18633    18632    -1     
=======================================
  Hits        15534    15534           
+ Misses       3099     3098    -1     
Impacted Files Coverage Δ
torch_geometric/data/remote_backend_utils.py 87.50% <100.00%> (+2.65%) ⬆️
torch_geometric/loader/link_neighbor_loader.py 94.47% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mananshah99 mananshah99 changed the title hotfix(loader): num_nodes instead of size in LinkNeighborLoader hotfix(loader): prefer using edge information in remote_backend_utils Aug 31, 2022
@mananshah99 mananshah99 changed the title hotfix(loader): prefer using edge information in remote_backend_utils hotfix(loader): check node types independently in remote_backend_utils Aug 31, 2022
@mananshah99 mananshah99 merged commit 65cbed2 into master Aug 31, 2022
@mananshah99 mananshah99 deleted the hotfix_remote_backend branch August 31, 2022 02:37
@rusty1s rusty1s added the data label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants