Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid modifying mode_kwargs in MultiAggregation #5601

Merged
merged 6 commits into from Oct 3, 2022

Conversation

lightaime
Copy link
Contributor

This PR avoids modifying mode_kwargs in MultiAggregation which is helpful if we want to share a mode_kwargs dict for different MultiAggregation layers.

@rusty1s rusty1s merged commit 5661020 into master Oct 3, 2022
@rusty1s rusty1s deleted the multi_aggr_fix_mode_kwargs branch October 3, 2022 18:34
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
* Avoid modifying mode_kwargs in MultiAggregation

* changelog

* update

* update

Co-authored-by: Guohao Li <lighaime@gmail.com>
Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants