Add ratio adjustment in RandomLinkSplit when not enough negative edges exist
#5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5642 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 349 349
Lines 19207 19213 +6
=======================================
+ Hits 16109 16115 +6
Misses 3098 3098
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
approved these changes
Oct 10, 2022
Comment on lines
209
to
211
| assert len(train_data.neg_edge_label) != 0 | ||
| assert len(val_data.neg_edge_label) != 0 | ||
| assert len(test_data.neg_edge_label) != 0 |
There was a problem hiding this comment.
Can we check here for the actual returned number of edges? I guess it may be
assert len(train_data.neg_edge_label) == 1
assert len(val_data.neg_edge_label) == 1
assert len(test_data.neg_edge_label) == 0There was a problem hiding this comment.
They're all non-zero, but yes we can check the exact size, I'll add that.
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Padarn
force-pushed
the
random_link_split_ratio
branch
from
e16ec3a
to
259e6ce
Compare
JakubPietrakIntel
pushed a commit
to JakubPietrakIntel/pytorch_geometric
that referenced
this pull request
Nov 25, 2022
…ges exist (pyg-team#5642) * add handling for not enough negative edges in random link split * add readme * Update torch_geometric/transforms/random_link_split.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/transforms/random_link_split.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * update tests * typos * typo Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses #5581
The problem being solved is that it is possible for there to not be enough negative edges available to satisfy the requested sampling ratio.
This change makes it so that in this case the ratio assigned to each split should reflect the desired ratio between the splits. I.e, the % assigned to each of train, test and validation is the same as requested.