Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] NELL PPI MoleculeNet QM7 ZINC #5678

Merged
merged 17 commits into from Oct 13, 2022
Merged

[Type Hints] NELL PPI MoleculeNet QM7 ZINC #5678

merged 17 commits into from Oct 13, 2022

Conversation

j-degroot
Copy link
Contributor

(sorry for the confusing reverts)

@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited

Codecov Report

Merging #5678 (bfbd42d) into master (2ff6ca2) will not change coverage.
The diff coverage is n/a.

❗ Current head bfbd42d differs from pull request most recent head 51ca877. Consider uploading reports for the commit 51ca877 to get more accurate results

@@           Coverage Diff           @@
##           master    #5678   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         349      349           
  Lines       19235    19235           
=======================================
  Hits        16119    16119           
  Misses       3116     3116

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

rusty1s
rusty1s approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

torch_geometric/datasets/molecule_net.py Outdated Show resolved Hide resolved
torch_geometric/datasets/nell.py Outdated Show resolved Hide resolved
torch_geometric/datasets/ppi.py Outdated Show resolved Hide resolved
torch_geometric/datasets/qm7.py Outdated Show resolved Hide resolved
torch_geometric/datasets/zinc.py Outdated Show resolved Hide resolved
@rusty1s rusty1s mentioned this pull request Oct 13, 2022
Closed
@rusty1s rusty1s enabled auto-merge (squash) October 13, 2022 10:55
@rusty1s rusty1s merged commit c156ab2 into pyg-team:master Oct 13, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@j-degroot @pre-commit-ci
@rusty1s @JakubPietrakIntel
[Type Hints] NELL PPI MoleculeNet QM7 ZINC (pyg-team#5678)
d2c9533 
(sorry for the confusing reverts)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@j-degroot j-degroot

Labels
0 - Priority P0 dataset type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-degroot @rusty1s