-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyTorch SparseTensor support for GCNConv
and gcn_norm
#6033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I think this gets really tricky to implement with TorchScript support. Sadly, the full tests do not pass in this PR but I also failed to make them work :(
Yeah, I have been blocked by this problem and also failed to find a solution these days. It seems we should drop the TorchScript support for PyTorch SparseTensor for now. |
Yeah, we don't have support for this anyway yet. The challenge is to ensure that original TorchScript support is maintained :( |
Noticed now. The problem seems related to |
Codecov Report
@@ Coverage Diff @@
## master #6033 +/- ##
=======================================
Coverage 84.35% 84.36%
=======================================
Files 365 365
Lines 20500 20512 +12
=======================================
+ Hits 17293 17305 +12
Misses 3207 3207
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@rusty1s I've made the tests passed with some changes on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite clever. Thank you!
For
gcn_norm
, a PyTorch SparseTensor is converted totorch_sparse.SparseTensor
and then converted back. Not really like this but have no better solution.