Explainability Dataset Task: ERGraph
#6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty1s
changed the title
ERGraph
4 tasks
…ric into benchmark_dataset
for more information, see https://pre-commit.ci
…ric into benchmark_dataset
- Added seed in graph generator - Added documentation in graph and motif classes - Simplified GraphGenerator base class - Fixed test error - Added tests - Modified Changelog
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…khil/pytorch_geometric into shenoynikhil/explain-er-dataset
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #6073 +/- ##
=======================================
Coverage 84.55% 84.56%
=======================================
Files 372 371 -1
Lines 20848 20840 -8
=======================================
- Hits 17629 17624 -5
+ Misses 3219 3216 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
added a commit
that referenced
this pull request
Dec 12, 2022
This PR implements benchmark dataset overall framework and API for generating benchmark datasets (#5817). Any feedback is appreciated, especially regarding the proposed architecture. ### Implementing a new graph generator - Create a class inside generators inheriting from GraphGenerator - Implement `generate_base_graph` using the provided methods (`generate_feature` and `attach_motif`) - See #6072 and #6073 to check how it was implemented - The current Motif generator used here will be replaced by #6179 ### Example for the final user ``` motif = Motif('house') generator = BAGraph(num_nodes=300, num_motifs=80, motif=motif) dataset = ExplainerDataset(generator) ``` TODO: - [x] Finish graph generator (provide all necessary methods: feature generator, label generator) - [x] Add tests - [x] Add to Change log - [x] Documentation Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
rusty1s
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ERGraph based on @rfdavid's PR #6072. Fixes task #5817.
TODO