Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load data.lightning #6140

Merged
merged 7 commits into from
Dec 5, 2022
Merged

Lazy load data.lightning #6140

merged 7 commits into from
Dec 5, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Dec 5, 2022

Most import time when calling import torch_geometric is spent on import pytorch_lightning. This PR moves the import of PL to its own sub-module - leading to a better experiencing when using raw PyG.

@rusty1s rusty1s changed the title Lazy load lightning.datamodule Lazy load data.lightning Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #6140 (620081c) into master (93289a4) will increase coverage by 0.00%.
The diff coverage is 92.59%.

@@           Coverage Diff           @@
##           master    #6140   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files         363      365    +2     
  Lines       20483    20502   +19     
=======================================
+ Hits        17278    17295   +17     
- Misses       3205     3207    +2     
Impacted Files Coverage Δ
torch_geometric/data/lightning/datamodule.py 55.90% <ø> (ø)
torch_geometric/lazy_loader.py 88.88% <88.88%> (ø)
torch_geometric/data/__init__.py 100.00% <100.00%> (ø)
torch_geometric/data/lightning/__init__.py 100.00% <100.00%> (ø)
torch_geometric/graphgym/imports.py 100.00% <100.00%> (ø)
torch_geometric/graphgym/logger.py 84.45% <100.00%> (-0.16%) ⬇️
torch_geometric/graphgym/train.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 4ed3614 into master Dec 5, 2022
@rusty1s rusty1s deleted the change_import_order branch December 5, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant