Correctly use edge weights in GDC example
#6159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to use GDC,you will find accuracy drop,because T.GDC( ) save the calculated edge weight in data.edge_ attr,not data.edge_weight. I directly change 'model(data.x, data.edge_index, data.edge_weight)' to 'model(data.x, data.edge_index, data.edge_attr)' in function train() and test() When the dataset's edge_weight is None ,like Cora,it's right.
Codecov Report
@@ Coverage Diff @@
## master #6159 +/- ##
==========================================
+ Coverage 84.40% 84.42% +0.01%
==========================================
Files 366 366
Lines 20558 20590 +32
==========================================
+ Hits 17352 17383 +31
- Misses 3206 3207 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to use GDC,you will find accuracy drop,because T.GDC( ) save the calculated edge weight in data.edge_ attr,not data.edge_weight.
I directly change 'model(data.x, data.edge_index, data.edge_weight)' to 'model(data.x, data.edge_index, data.edge_attr)' in function train() and test().
When data.edge_weight is None ,like Cora,it's right.