Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer correct CUDA device ID in profileit decorator #6164

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Infer correct CUDA device ID in profileit decorator #6164

merged 5 commits into from
Dec 7, 2022

Conversation

venomouscyanide
Copy link
Contributor

@venomouscyanide venomouscyanide commented Dec 7, 2022 •
edited

No description provided.

@venomouscyanide venomouscyanide changed the title Infer CUDA device ID from profileit decorator args to profile the cor… Infer CUDA device ID from profileit decorator args Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022 •
edited

Codecov Report

Merging #6164 (a4fc47a) into master (a4fc47a) will not change coverage.
The diff coverage is n/a.

❗ Current head a4fc47a differs from pull request most recent head 1748d7c. Consider uploading reports for the commit 1748d7c to get more accurate results

@@           Coverage Diff           @@
##           master    #6164   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files         366      366           
  Lines       20558    20558           
=======================================
  Hits        17352    17352           
  Misses       3206     3206

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title Infer CUDA device ID from profileit decorator args Infer correct CUDA device ID in profileit decorator Dec 7, 2022
@rusty1s rusty1s marked this pull request as ready for review December 7, 2022 06:29
rusty1s
rusty1s approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@rusty1s rusty1s enabled auto-merge (squash) December 7, 2022 06:30
@rusty1s rusty1s merged commit 9cacd85 into pyg-team:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@venomouscyanide venomouscyanide

Labels
0 - Priority P0 benchmark bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@venomouscyanide @rusty1s