Move ExplainerConfig arguments to Explainer class
#6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6176 +/- ##
==========================================
- Coverage 84.37% 84.37% -0.01%
==========================================
Files 366 366
Lines 20544 20548 +4
==========================================
+ Hits 17335 17338 +3
- Misses 3209 3210 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wsad1
reviewed
Dec 8, 2022
| @@ -23,27 +24,49 @@ class Explainer: | |||
| Args: | |||
| model (torch.nn.Module): The model to explain. | |||
| algorithm (ExplainerAlgorithm): The explanation algorithm. | |||
| explainer_config (ExplainerConfig): The explainer configuration. | |||
| explanation_type (ExplanationType or str): The type of explanation to | |||
There was a problem hiding this comment.
Given this do we also plan to move ThresholdConfig args to the top level?
There was a problem hiding this comment.
I don't plan to. Discussed with @RBendias and we both found it weird that the Explainer expects an ExplainerConfig - these should be top-level args. I still would like to keep the grouping of args of ModelConfig and ThresholdConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Explainershould take theExplainerConfigarguments as top-level arguments.