pyg-lib integration in HGTConv
#6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty1s
reviewed
Dec 8, 2022
rusty1s
changed the title
pyg-lib integration in HGTConv
rusty1s
added a commit
to pyg-team/pyg-lib
that referenced
this pull request
Dec 9, 2022
for pyg-team/pytorch_geometric#6178 Co-authored-by: Rishi Puri <riship@riship-mlt.client.nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
puririshi98
changed the title
pyg-lib integration in HGTConvpyg-lib integration in HGTConv
|
still need to test and benchmark it but done w/ an initial draft |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…geometric into hgtconv_pyglib
for more information, see https://pre-commit.ci
…geometric into hgtconv_pyglib
wsad1
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Thanks @puririshi98 for all the work.
@rusty1s appreciate a quick look.
|
basic correctness passes: https://github.com/puririshi98/rgcn_pyg_lib_forward_bench/blob/main/hgt_correctness.py |
rusty1s
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready🎉
3x speedup. As part of my blog I will do a more extensive benchmark to see how runtime for for-loop, segment_matmul, and group_matmul backends of HGT compare agaisnt eachother
smaller heterograph:
1.6x speedup
scaling:
For interactive graph: https://github.com/puririshi98/rgcn_pyg_lib_forward_bench/blob/main/3d_plot.py