Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore correct order in the output of HeteroLinear in case of is_sorted=False #6198

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

toenshoff
Copy link
Contributor

If "is_sorted=False", the output of the forward pass will be unsorted to the original vertex order of the input.

If "is_sorted=False", the output will be unsorted to the original vertex order of the input.
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #6198 (139aad6) into master (f82d6a2) will increase coverage by 0.06%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #6198      +/-   ##
==========================================
+ Coverage   84.49%   84.55%   +0.06%     
==========================================
  Files         371      371              
  Lines       20741    20845     +104     
==========================================
+ Hits        17525    17626     +101     
- Misses       3216     3219       +3     
Impacted Files Coverage Δ
torch_geometric/nn/dense/linear.py 85.40% <40.00%> (-1.72%) ⬇️
torch_geometric/explain/algorithm/gnn_explainer.py 95.18% <0.00%> (-1.12%) ⬇️
...rch_geometric/explain/algorithm/dummy_explainer.py 93.75% <0.00%> (-0.37%) ⬇️
torch_geometric/explain/explainer.py 100.00% <0.00%> (ø)
torch_geometric/explain/explanation.py 100.00% <0.00%> (ø)
torch_geometric/nn/conv/gcn2_conv.py 92.64% <0.00%> (+0.10%) ⬆️
torch_geometric/explain/algorithm/base.py 96.72% <0.00%> (+0.11%) ⬆️
torch_geometric/nn/conv/appnp.py 78.68% <0.00%> (+0.35%) ⬆️
torch_geometric/data/hetero_data.py 95.65% <0.00%> (+0.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a great catch. Thank you! What a bad mistake on our end :(

@rusty1s rusty1s linked an issue Dec 12, 2022 that may be closed by this pull request
@rusty1s rusty1s changed the title Restore vertex order in the output of HeteroLinear. Restore correct order in the output of HeteroLinear in case of is_sorted=False Dec 12, 2022
@rusty1s rusty1s merged commit 25abbb1 into pyg-team:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent output of HeteroLinear when '"is_sorted=False"
2 participants