Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explainability Dataset Task: GridGraph #6220

Merged
merged 10 commits into from
Dec 13, 2022

Conversation

shenoynikhil
Copy link
Contributor

@shenoynikhil shenoynikhil commented Dec 13, 2022

Adds GridGraph. Fixes task #5817.

from torch_geometric.datasets.generators import GridGraph

motif = Motif(structure='house')
generator = GridGraph(height=10, width=10, dtype=torch.float)
dataset = ExplainerDataset(generator=generator)

TODO

  • Tests
  • ChangeLog

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #6220 (5962c2c) into master (56698a7) will not change coverage.
The diff coverage is n/a.

❗ Current head 5962c2c differs from pull request most recent head 2c4f21b. Consider uploading reports for the commit 2c4f21b to get more accurate results

@@           Coverage Diff           @@
##           master    #6220   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files         372      372           
  Lines       20805    20805           
=======================================
  Hits        17584    17584           
  Misses       3221     3221           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shenoynikhil shenoynikhil marked this pull request as ready for review December 13, 2022 03:20
@shenoynikhil
Copy link
Contributor Author

@rusty1s Maybe you can have a look at this PR.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great :)

torch_geometric/datasets/graph_generator/__init__.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
torch_geometric/datasets/graph_generator/grid_graph.py Outdated Show resolved Hide resolved
torch_geometric/datasets/graph_generator/grid_graph.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) December 13, 2022 09:39
@rusty1s rusty1s merged commit 90de72f into pyg-team:master Dec 13, 2022
@shenoynikhil shenoynikhil deleted the shenoynikhil/grid-graph branch December 13, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants