-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explainability Infection Benchmark #6222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6222 +/- ##
==========================================
- Coverage 86.38% 84.51% -1.87%
==========================================
Files 376 372 -4
Lines 20942 20805 -137
==========================================
- Hits 18090 17584 -506
- Misses 2852 3221 +369
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Overall it looks good to me. Just a few clarification questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for adding this. It looks good to me. In general, I noticed that the description of the arguments (seeds, max_path_lenght and num_infected) do not include the information that if a list is provided, that this list needs to be as long as the number of graphs and that each element is used per graph.
""" | ||
def __init__( | ||
self, | ||
graph_generator: Union[GraphGenerator, str], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using a default here as well?
This PR implements Infection benchmark dataset as mentioned in #5817
Checklist