Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the GraphMaskExplainer algorithm #6284

Merged
merged 18 commits into from
Jan 21, 2023
Merged

Added the GraphMaskExplainer algorithm #6284

merged 18 commits into from
Jan 21, 2023

Conversation

fork123aniket
Copy link
Contributor

This PR contains implementation of how to compute layer-wise weights for each edge in order to produce explanations for node-level, edge-level, and graph-level tasks. Furthermore, this implementation is different from authors' original implementation and is fast and more memory efficient than theirs. Have added Tests and Examples of the proposed implementation in order to make the overall approach understandable.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #6284 (112703f) into master (2ca6180) will increase coverage by 0.06%.
The diff coverage is 90.34%.

@@            Coverage Diff             @@
##           master    #6284      +/-   ##
==========================================
+ Coverage   85.51%   85.57%   +0.06%     
==========================================
  Files         403      404       +1     
  Lines       22024    22313     +289     
==========================================
+ Hits        18834    19095     +261     
- Misses       3190     3218      +28     
Impacted Files Coverage Δ
...h_geometric/contrib/explain/graphmask_explainer.py 90.27% <90.27%> (ø)
torch_geometric/contrib/explain/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fork123aniket
Copy link
Contributor Author

Hi @rusty1s , I am still seeking your attention on this. May I get some review comments on this PR, please??

Thank you...

@rusty1s
Copy link
Member

rusty1s commented Jan 16, 2023

Yes, we discussed how to deal with this PR and have plans to move this to torch_geometric.contrib.explain first in order to get this in ASAP. Would that work for you?

@fork123aniket
Copy link
Contributor Author

Yes, it will. Please move this PR to torch_geometric.contrib.explain and then we'll take this PR forward from there. Thank you!!

@fork123aniket
Copy link
Contributor Author

Hi @rusty1s, Any updates?? Can we do something to review and merge this PR ASAP??

@rusty1s rusty1s changed the title Explainability for GNNs Added the GraphMaskExplainer algorithm Jan 21, 2023
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to contrib - feel free to extend and clean-up in a follow-up. There were some device issues I needed to fix.

@rusty1s rusty1s merged commit 12ef4bf into pyg-team:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants