Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GATConv model using the primitives in cugraph-ops #6412

Merged
merged 13 commits into from
Feb 3, 2023
Merged

Add a GATConv model using the primitives in cugraph-ops #6412

merged 13 commits into from
Feb 3, 2023

Conversation

tingyu66
Copy link
Contributor

This PR adds a GAT model torch_geometric.nn.GATConvCuGraph that leverages the optimized aggregation function in cugraph-ops, similar to #6278.

Fixes https://github.com/rapidsai/cugraph-ops/issues/182.

@tingyu66 tingyu66 marked this pull request as ready for review January 25, 2023 02:59
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #6412 (18c9c64) into master (ab3efed) will decrease coverage by 1.61%.
The diff coverage is 92.30%.

❗ Current head 18c9c64 differs from pull request most recent head 45afb9b. Consider uploading reports for the commit 45afb9b to get more accurate results

@@            Coverage Diff             @@
##           master    #6412      +/-   ##
==========================================
- Coverage   87.85%   86.25%   -1.61%     
==========================================
  Files         416      417       +1     
  Lines       22808    22779      -29     
==========================================
- Hits        20039    19649     -390     
- Misses       2769     3130     +361     
Impacted Files Coverage Δ
torch_geometric/nn/conv/cugraph/sage_conv.py 100.00% <ø> (+20.00%) ⬆️
torch_geometric/nn/conv/cugraph/base.py 85.71% <75.00%> (-14.29%) ⬇️
torch_geometric/nn/conv/__init__.py 100.00% <100.00%> (ø)
torch_geometric/nn/conv/cugraph/__init__.py 100.00% <100.00%> (ø)
torch_geometric/nn/conv/cugraph/gat_conv.py 100.00% <100.00%> (ø)
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 17.84% <0.00%> (-49.66%) ⬇️
torch_geometric/visualization/graph.py 68.25% <0.00%> (-26.99%) ⬇️
torch_geometric/nn/conv/utils/typing.py 83.75% <0.00%> (-15.00%) ⬇️
torch_geometric/nn/pool/asap.py 92.00% <0.00%> (-8.00%) ⬇️
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tingyu66
Copy link
Contributor Author

tingyu66 commented Feb 2, 2023

@rusty1s GATConv updated. I removed add_self_loops option here, since it is better for users to change the COO directly IMO.

@rusty1s rusty1s enabled auto-merge (squash) February 3, 2023 17:53
@rusty1s rusty1s merged commit 06c3043 into pyg-team:master Feb 3, 2023
@tingyu66 tingyu66 deleted the cugraphops-gatconv branch February 7, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants