Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eval_loader_kwargs in lightning modules #6456

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Jan 18, 2023

Need to copy the dictionary before modifying it.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #6456 (ac64dd9) into master (02bd302) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #6456      +/-   ##
==========================================
+ Coverage   85.19%   85.21%   +0.01%     
==========================================
  Files         402      402              
  Lines       21766    21760       -6     
==========================================
- Hits        18544    18543       -1     
+ Misses       3222     3217       -5     
Impacted Files Coverage Δ
torch_geometric/data/lightning/datamodule.py 68.96% <87.50%> (+1.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit c3eae23 into master Jan 18, 2023
@rusty1s rusty1s deleted the fix_eval_loader_kwargs branch January 18, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant