Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pooling: Base classes for Graph Pooling framework #6540

Merged
merged 13 commits into from
Jan 28, 2023
Merged

Pooling: Base classes for Graph Pooling framework #6540

merged 13 commits into from
Jan 28, 2023

Conversation

wsad1
Copy link
Member

@wsad1 wsad1 commented Jan 28, 2023 •
edited

#6455
Adds base classes Select, Connect and Pooling for the Graph pooling framework.
TODO in this PR

  1. Implement TopkPooling with this framework to verify the interface.

@wsad1 wsad1 self-assigned this Jan 28, 2023
@github-actions github-actions bot added the nn label Jan 28, 2023
@wsad1 wsad1 added the feature label Jan 28, 2023
@codecov
Copy link

codecov bot commented Jan 28, 2023 •
edited

Codecov Report

Merging #6540 (2556eef) into master (2f7c25f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6540      +/-   ##
==========================================
+ Coverage   85.79%   85.82%   +0.03%     
==========================================
  Files         406      411       +5     
  Lines       22730    22785      +55     
==========================================
+ Hits        19501    19556      +55     
  Misses       3229     3229
Impacted Files Coverage Δ
torch_geometric/nn/pool/base.py 100.00% <100.00%> (ø)
torch_geometric/nn/pool/connect/__init__.py 100.00% <100.00%> (ø)
torch_geometric/nn/pool/connect/base.py 100.00% <100.00%> (ø)
torch_geometric/nn/pool/select/__init__.py 100.00% <100.00%> (ø)
torch_geometric/nn/pool/select/base.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wsad1 wsad1 marked this pull request as ready for review January 28, 2023 14:03
@rusty1s rusty1s changed the title Pooling: Base classes for Graph Pooling framework. Pooling: Base classes for Graph Pooling framework Jan 28, 2023
@rusty1s rusty1s merged commit 743a6b8 into master Jan 28, 2023
@rusty1s rusty1s deleted the pooling_frame_jinu branch January 28, 2023 18:32
@wsad1 wsad1 mentioned this pull request Jan 29, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wsad1 wsad1

Labels
0 - Priority P0 feature nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wsad1 @rusty1s