Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAMultiShapes dataset #6541

Merged
merged 15 commits into from
Jan 28, 2023
Merged

BAMultiShapes dataset #6541

merged 15 commits into from
Jan 28, 2023

Conversation

steveazzolin
Copy link
Contributor

This PR integrates the new dataset proposed in Azzolin et al.
Specifically:

  • BAMultiShapesDataset loads the original dataset as defined in the paper
  • BAMultiShapesGraph is a generator to create a new instance of the dataset

My original goal was to incorporate BAMultiShapesGraph into ExplainerDataset. However, the code of such Dataset seems tailored to generate node classification explainability datasets, and I found that including it would result in major modifications to its original implementation, which I was not particularly liking from a modular-code point of view. Hence, I proposed an ad-hoc Generator

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #6541 (ab8db5a) into master (743a6b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6541   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files         411      411           
  Lines       22785    22785           
=======================================
  Hits        19556    19556           
  Misses       3229     3229           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title Adding BAMultiShapes dataset BAMultiShapes dataset Jan 28, 2023
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can we add the graph generator code in a separate PR? I am not totally sure if that should be done as a GraphGenerator - the underlying implementation should expect a GraphGenerator and a list of Motifs as input to generate the dataset. WDYT?

@rusty1s rusty1s merged commit 18aa876 into pyg-team:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants