Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Coverage] test_profiler #6573

Merged
merged 17 commits into from
Feb 3, 2023
Merged

Conversation

LukeLIN-web
Copy link
Contributor

rename group_by(events, keyfn): to _group_by(events, keyfn):
rename test_get_gpu_memory_from_gc():
fix print function.
add test_profiler

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #6573 (9e206ac) into master (5a277a2) will increase coverage by 0.89%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master    #6573      +/-   ##
==========================================
+ Coverage   86.26%   87.15%   +0.89%     
==========================================
  Files         418      418              
  Lines       22787    22788       +1     
==========================================
+ Hits        19658    19862     +204     
+ Misses       3129     2926     -203     
Impacted Files Coverage Δ
torch_geometric/profile/profiler.py 90.00% <93.33%> (+90.00%) ⬆️
torch_geometric/profile/utils.py 74.60% <0.00%> (+9.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LukeLIN-web
Copy link
Contributor Author

LukeLIN-web commented Feb 2, 2023

I thought that __str__ will be tested by print, but not, why?
Why __init__ self._model = model following is not tested?

test/profile/test_profiler.py Outdated Show resolved Hide resolved
test/profile/test_profiler.py Outdated Show resolved Hide resolved
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is sadly a bit unfinished, so it's quite hard to add meaningful tests to it. I'm sorry :( Still, this looks good. Thank you very much!

@rusty1s rusty1s merged commit d668b50 into pyg-team:master Feb 3, 2023
@LukeLIN-web LukeLIN-web deleted the testprofiler branch February 11, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants