Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cat option to the aggr argument for HeteroConv #6634

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

DylanSand
Copy link
Contributor

This new aggregation type will allow users to have the option of having the features from different edge types be concatenated together during the grouping stage of HeteroConv's forward function.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #6634 (0726163) into master (a730437) will increase coverage by 0.00%.
The diff coverage is 91.66%.

❗ Current head 0726163 differs from pull request most recent head 1d70f56. Consider uploading reports for the commit 1d70f56 to get more accurate results

@@           Coverage Diff           @@
##           master    #6634   +/-   ##
=======================================
  Coverage   87.55%   87.56%           
=======================================
  Files         422      422           
  Lines       22879    22886    +7     
=======================================
+ Hits        20032    20039    +7     
  Misses       2847     2847           
Impacted Files Coverage Δ
torch_geometric/utils/scatter.py 72.72% <ø> (ø)
torch_geometric/nn/conv/hgt_conv.py 96.07% <50.00%> (-0.93%) ⬇️
torch_geometric/data/data.py 88.86% <100.00%> (+0.02%) ⬆️
torch_geometric/data/hetero_data.py 90.63% <100.00%> (+0.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

torch_geometric/nn/conv/hgt_conv.py Outdated Show resolved Hide resolved
@rusty1s rusty1s added the feature label Feb 7, 2023
@rusty1s rusty1s enabled auto-merge (squash) February 7, 2023 16:12
@rusty1s rusty1s merged commit a5e5a48 into master Feb 7, 2023
@rusty1s rusty1s deleted the add-hetero-conv-concat-aggr branch February 7, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants