Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Coverage] utils/loop.py #6647

Merged
merged 13 commits into from
Feb 10, 2023
Merged

Conversation

akash-vartak
Copy link
Member

Improving code coverage for utils/loop.py

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #6647 (36b4635) into master (cfacfa5) will decrease coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6647      +/-   ##
==========================================
- Coverage   89.39%   87.84%   -1.56%     
==========================================
  Files         422      422              
  Lines       22946    22907      -39     
==========================================
- Hits        20513    20123     -390     
- Misses       2433     2784     +351     
Impacted Files Coverage Δ
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 17.66% <0.00%> (-49.78%) ⬇️
torch_geometric/visualization/graph.py 68.25% <0.00%> (-26.99%) ⬇️
torch_geometric/nn/conv/utils/typing.py 83.75% <0.00%> (-15.00%) ⬇️
torch_geometric/nn/pool/asap.py 91.89% <0.00%> (-8.11%) ⬇️
torch_geometric/resolver.py 82.75% <0.00%> (-6.90%) ⬇️
torch_geometric/nn/dense/linear.py 89.13% <0.00%> (-5.84%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/nn/models/attentive_fp.py 95.83% <0.00%> (-4.17%) ⬇️
torch_geometric/sampler/neighbor_sampler.py 91.56% <0.00%> (-3.22%) ⬇️
... and 32 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akash-vartak akash-vartak marked this pull request as ready for review February 8, 2023 20:31
@akash-vartak
Copy link
Member Author

Need help to test Line 293 inside add_remaining_self_loops()

@akash-vartak akash-vartak changed the title [Code Coverage] utils/test_loop.py [Code Coverage] utils/loop.py Feb 9, 2023
@wsad1 wsad1 merged commit 2d8c532 into pyg-team:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants