Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Coverage] utils/num_nodes.py #6669

Merged
merged 9 commits into from
Feb 11, 2023

Conversation

shhs29
Copy link
Contributor

@shhs29 shhs29 commented Feb 10, 2023

I did not write test for this line: max(edge_index.size(0), edge_index.size(1)). I am unsure if we need this at all.

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #6669 (0baaa94) into master (fc741e9) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 0baaa94 differs from pull request most recent head c95ab76. Consider uploading reports for the commit c95ab76 to get more accurate results

@@            Coverage Diff             @@
##           master    #6669      +/-   ##
==========================================
+ Coverage   88.44%   88.49%   +0.05%     
==========================================
  Files         422      422              
  Lines       22908    22908              
==========================================
+ Hits        20261    20273      +12     
+ Misses       2647     2635      -12     
Impacted Files Coverage Δ
torch_geometric/utils/num_nodes.py 90.00% <0.00%> (+40.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

test/utils/test_num_nodes.py Outdated Show resolved Hide resolved
test/utils/test_num_nodes.py Outdated Show resolved Hide resolved
test/utils/test_num_nodes.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) February 11, 2023 20:38
@rusty1s rusty1s merged commit 9b8df7d into pyg-team:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants