Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Coverage] transforms/gcn_norm.py #6673

Merged
merged 12 commits into from
Feb 12, 2023

Conversation

venomouscyanide
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #6673 (2890e20) into master (2a80dae) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6673      +/-   ##
==========================================
+ Coverage   88.59%   88.63%   +0.04%     
==========================================
  Files         423      423              
  Lines       23114    23113       -1     
==========================================
+ Hits        20477    20486       +9     
+ Misses       2637     2627      -10     
Impacted Files Coverage Δ
torch_geometric/transforms/gcn_norm.py 100.00% <100.00%> (+55.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@venomouscyanide
Copy link
Contributor Author

Currently missing coverage for adj_t flow. I am getting an error when trying our this testing snippet

edge_index = torch.tensor([[0, 1, 1, 2], [1, 0, 2, 1]])
adj_t = SparseTensor.from_edge_index(edge_index, sparse_sizes=(3, 3))
data = Data(adj_t=adj_t)
data = GCNNorm(add_self_loops=False)(data)

@venomouscyanide venomouscyanide marked this pull request as draft February 11, 2023 05:50
@venomouscyanide venomouscyanide marked this pull request as ready for review February 11, 2023 05:50
@rusty1s rusty1s changed the title [Code Coverage] transforms/gcn_norm.py [Code Coverage] transforms/gcn_norm.py Feb 11, 2023
@rusty1s rusty1s enabled auto-merge (squash) February 12, 2023 10:02
@rusty1s rusty1s merged commit 105c0d8 into pyg-team:master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants