Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Coverage] data/lightning/datamodule.py #6858

Merged
merged 8 commits into from
Mar 11, 2023

Conversation

zechengz
Copy link
Member

@zechengz zechengz commented Mar 6, 2023

Code coverage improvement for data/lightning/datamodule.py

It seems that for torchmetrics.Accuracy, task is required after 0.11.0 [see this] Should we also update the torchmetrics to the newest version (in the workflow)?

Also, only tested on a single GPU, not sure following line of code is correct

offset += devices * math.ceil(1000 / (devices * batch_size))

@zechengz zechengz requested review from rusty1s and wsad1 March 6, 2023 10:00
@zechengz zechengz self-assigned this Mar 6, 2023
@zechengz zechengz marked this pull request as ready for review March 6, 2023 10:06
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #6858 (0c2dc9e) into master (06bff37) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6858   +/-   ##
=======================================
  Coverage   91.55%   91.56%           
=======================================
  Files         427      427           
  Lines       23177    23177           
=======================================
+ Hits        21220    21222    +2     
+ Misses       1957     1955    -2     
Impacted Files Coverage Δ
torch_geometric/data/lightning/datamodule.py 74.88% <ø> (+0.89%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

test/data/lightning/test_datamodule.py Show resolved Hide resolved
@zechengz zechengz merged commit d83d74e into pyg-team:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants