Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch Sparse Tensor support: LEConv, LGConv, NNConv, PANConv, SignedConv, and WLConv #6936

Merged
merged 11 commits into from
Mar 20, 2023

Conversation

EdisonLeeeee
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #6936 (1da0fc5) into master (d3043d8) will increase coverage by 0.01%.
The diff coverage is 94.44%.

❗ Current head 1da0fc5 differs from pull request most recent head 07fd9c1. Consider uploading reports for the commit 07fd9c1 to get more accurate results

@@            Coverage Diff             @@
##           master    #6936      +/-   ##
==========================================
+ Coverage   91.43%   91.45%   +0.01%     
==========================================
  Files         431      431              
  Lines       23446    23453       +7     
==========================================
+ Hits        21439    21449      +10     
+ Misses       2007     2004       -3     
Impacted Files Coverage Δ
torch_geometric/utils/sparse.py 91.78% <ø> (+5.47%) ⬆️
torch_geometric/nn/conv/pan_conv.py 96.77% <85.71%> (-1.51%) ⬇️
torch_geometric/nn/conv/signed_conv.py 100.00% <100.00%> (ø)
torch_geometric/nn/conv/wl_conv.py 97.67% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are making the assumption that if is_torch_sparse_tensor then the tensor is of format coo. Like for example in wl_conv we use from_torch_sparse_coo_tensor.

torch_geometric/nn/conv/pan_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/pan_conv.py Outdated Show resolved Hide resolved
test/nn/conv/test_signed_conv.py Show resolved Hide resolved
@github-actions github-actions bot added the utils label Mar 20, 2023
@rusty1s rusty1s enabled auto-merge (squash) March 20, 2023 06:22
@rusty1s rusty1s merged commit 81f2daa into master Mar 20, 2023
@rusty1s rusty1s deleted the sparse_tensor2 branch March 20, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants