-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cugraph conv layers for pylibcugraphops=23.04
#7023
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7023 +/- ##
==========================================
- Coverage 91.79% 91.26% -0.53%
==========================================
Files 435 436 +1
Lines 23776 23905 +129
==========================================
- Hits 21826 21818 -8
- Misses 1950 2087 +137
... and 49 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Feel free to merge once you released the new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side, too, if all the tests are passing. 23.04 RAPIDS release should be on April 12th, so this will stay blocked for at least another 2 weeks.
Hi @rusty1s, we have a bit of a compatibility issue here among RAPIDS packages, due to the the different release cadence of Rapids and PyG. The upcoming cugraph 23.04 release is pinned to PyG 2.3.0, however, PyG 2.3.0 was release with cugraph-ops 23.02 (since we did not want to break users at the time). Is there a chance that we can have a minor release that incorporates this PR? Apologies for the late communication, we will plan this ahead in future releases. |
I think this is possible. Let's discuss in person today. |
@rusty1s I repurpose this PR to support both 23.02 and 23.04 APIs, feel free to check again. Thanks! |
Hey @rusty1s , just want to follow up with the minor release request. Do we have any blockers? Thanks! |
No blockers, let me create |
This PR updates cugraph models to reflect breaking changes in `pylibcugraphops=23.04`. ~~Right now, it is **blocked** by RAPIDS 23.04 release.~~ CC: @MatthiasKohl @stadlmax --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This PR updates cugraph models to reflect breaking changes in
pylibcugraphops=23.04
.Right now, it is blocked by RAPIDS 23.04 release.CC: @MatthiasKohl @stadlmax