Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cugraph conv layers for pylibcugraphops=23.04 #7023

Merged
merged 9 commits into from
Mar 31, 2023

Conversation

tingyu66
Copy link
Contributor

@tingyu66 tingyu66 commented Mar 23, 2023

This PR updates cugraph models to reflect breaking changes in pylibcugraphops=23.04.
Right now, it is blocked by RAPIDS 23.04 release.

CC: @MatthiasKohl @stadlmax

@tingyu66 tingyu66 marked this pull request as draft March 23, 2023 16:15
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #7023 (51f6a12) into master (f0c7218) will decrease coverage by 0.53%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #7023      +/-   ##
==========================================
- Coverage   91.79%   91.26%   -0.53%     
==========================================
  Files         435      436       +1     
  Lines       23776    23905     +129     
==========================================
- Hits        21826    21818       -8     
- Misses       1950     2087     +137     
Impacted Files Coverage Δ
torch_geometric/nn/conv/cugraph/base.py 100.00% <ø> (ø)
torch_geometric/nn/conv/cugraph/gat_conv.py 90.90% <75.00%> (-9.10%) ⬇️
torch_geometric/nn/conv/cugraph/rgcn_conv.py 90.90% <75.00%> (-9.10%) ⬇️
torch_geometric/nn/conv/cugraph/sage_conv.py 90.00% <75.00%> (-10.00%) ⬇️

... and 49 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge once you released the new version.

Copy link

@MatthiasKohl MatthiasKohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, too, if all the tests are passing. 23.04 RAPIDS release should be on April 12th, so this will stay blocked for at least another 2 weeks.

@tingyu66
Copy link
Contributor Author

tingyu66 commented Mar 28, 2023

Hi @rusty1s, we have a bit of a compatibility issue here among RAPIDS packages, due to the the different release cadence of Rapids and PyG. The upcoming cugraph 23.04 release is pinned to PyG 2.3.0, however, PyG 2.3.0 was release with cugraph-ops 23.02 (since we did not want to break users at the time).

Is there a chance that we can have a minor release that incorporates this PR? Apologies for the late communication, we will plan this ahead in future releases.

CC: @MatthiasKohl @alexbarghi-nv

@rusty1s
Copy link
Member

rusty1s commented Mar 29, 2023

I think this is possible. Let's discuss in person today.

@tingyu66
Copy link
Contributor Author

@rusty1s I repurpose this PR to support both 23.02 and 23.04 APIs, feel free to check again. Thanks!

@tingyu66 tingyu66 marked this pull request as ready for review March 31, 2023 01:43
@rusty1s rusty1s merged commit 7529152 into pyg-team:master Mar 31, 2023
@tingyu66 tingyu66 deleted the update-cugraphops-2304 branch March 31, 2023 16:46
@tingyu66
Copy link
Contributor Author

I think this is possible. Let's discuss in person today.

Hey @rusty1s , just want to follow up with the minor release request. Do we have any blockers? Thanks!

@rusty1s
Copy link
Member

rusty1s commented Apr 25, 2023

No blockers, let me create 2.3.1 tomorrow :)

rusty1s pushed a commit that referenced this pull request Apr 27, 2023
This PR updates cugraph models to reflect breaking changes in
`pylibcugraphops=23.04`.
~~Right now, it is **blocked** by RAPIDS 23.04 release.~~

CC: @MatthiasKohl @stadlmax

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants