Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to preserve directed graphs in CitationFull datasets #7275

Merged
merged 4 commits into from
May 2, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented May 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #7275 (18e7324) into master (483ef6a) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #7275      +/-   ##
==========================================
- Coverage   91.62%   91.62%   -0.01%     
==========================================
  Files         437      437              
  Lines       24206    24209       +3     
==========================================
+ Hits        22179    22181       +2     
- Misses       2027     2028       +1     
Impacted Files Coverage Δ
torch_geometric/io/npz.py 39.13% <71.42%> (+4.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 84ae27d into master May 2, 2023
13 of 14 checks passed
@rusty1s rusty1s deleted the to_undirected_data branch May 2, 2023 12:12
@joeloskarsson
Copy link

Hi, does this work correctly? The argument to_undirected seems to be unused in read_npz, in particular it is not fed forward to the parse_npz function. I'm assuming parse_npz will always make the graphs undirected then, but let me know if I am missing something!

@EdisonLeeeee
Copy link
Contributor

Thank you for pointing it out. You are right and it has been fixed via #7843

@joeloskarsson
Copy link

Cool, thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants