Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python fallbacks in voxel_grid #7528

Merged
merged 4 commits into from Jun 7, 2023

Conversation

piotrchmiel
Copy link
Contributor

Replace pure python ops, by torch ops in order to avoid graph break in torch.compile.

@piotrchmiel piotrchmiel force-pushed the pchmiel/voxel_grid branch 2 times, most recently from 48215f1 to dcab3fb Compare June 6, 2023 08:26
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #7528 (9f8c8ca) into master (a6a1f46) will decrease coverage by 0.02%.
The diff coverage is 86.20%.

❗ Current head 9f8c8ca differs from pull request most recent head 6837c55. Consider uploading reports for the commit 6837c55 to get more accurate results

@@            Coverage Diff             @@
##           master    #7528      +/-   ##
==========================================
- Coverage   91.38%   91.37%   -0.02%     
==========================================
  Files         447      447              
  Lines       24907    24922      +15     
==========================================
+ Hits        22762    22773      +11     
- Misses       2145     2149       +4     
Impacted Files Coverage Δ
torch_geometric/utils/repeat.py 84.00% <71.42%> (-16.00%) ⬇️
torch_geometric/nn/pool/voxel_grid.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Replace pure python ops, by torch ops in order to avoid graph
break in torch.compile.
@rusty1s rusty1s changed the title Remove python fallbacks in voxel grid Remove python fallbacks in `voxel grid Jun 7, 2023
@rusty1s rusty1s changed the title Remove python fallbacks in `voxel grid Remove python fallbacks in voxel_grid Jun 7, 2023
@rusty1s rusty1s enabled auto-merge (squash) June 7, 2023 18:32
@rusty1s rusty1s merged commit ca5ba4c into pyg-team:master Jun 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants