Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a detailed warning if torch_cluster is not installed #7785

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

EdisonLeeeee
Copy link
Contributor

Gives users a more detailed warning message if torch_cluster is not installed when using a related API, see also #7783

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks :)

torch_geometric/nn/pool/__init__.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) July 21, 2023 07:35
@rusty1s rusty1s changed the title Added a detailed warning if torch_cluster is not installed. Added a detailed warning if torch_cluster is not installed Jul 21, 2023
@rusty1s rusty1s disabled auto-merge July 21, 2023 07:35
@rusty1s rusty1s enabled auto-merge (squash) July 21, 2023 07:35
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #7785 (2075124) into master (34890a5) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

❗ Current head 2075124 differs from pull request most recent head c1e58a2. Consider uploading reports for the commit c1e58a2 to get more accurate results

@@            Coverage Diff             @@
##           master    #7785      +/-   ##
==========================================
- Coverage   91.95%   91.59%   -0.37%     
==========================================
  Files         453      453              
  Lines       25554    25547       -7     
==========================================
- Hits        23499    23399     -100     
- Misses       2055     2148      +93     
Impacted Files Coverage Δ
torch_geometric/typing.py 89.85% <ø> (-10.15%) ⬇️
torch_geometric/nn/pool/__init__.py 72.72% <100.00%> (-1.19%) ⬇️
torch_geometric/utils/dropout.py 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s requested a review from wsad1 as a code owner July 21, 2023 07:44
@github-actions github-actions bot added the utils label Jul 21, 2023
@rusty1s rusty1s merged commit 8cd05f8 into master Jul 21, 2023
14 checks passed
@rusty1s rusty1s deleted the torch_cluster_warning branch July 21, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants