Measure test coverage of exceptions #7823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty1s
approved these changes
Aug 1, 2023
rusty1s
approved these changes
Aug 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #7823 +/- ##
==========================================
- Coverage 91.94% 89.82% -2.13%
==========================================
Files 455 455
Lines 25673 26327 +654
==========================================
+ Hits 23605 23647 +42
- Misses 2068 2680 +612 see 154 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6528.
IMO, exceptions are also part of the public API so we should measure the test coverage over them, but feel free to close this PR if you think otherwise ;)