Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XPU device in PrefetchLoader #7918

Merged
merged 8 commits into from
Aug 23, 2023

Conversation

DamianSzwichtenberg
Copy link
Member

Device abstraction is now covered by an internal class, called PrefetchLoaderDevice. It handles the device selection mechanism, stream creation, and synchronization.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #7918 (03411f6) into master (1dd13de) will decrease coverage by 0.56%.
The diff coverage is 65.78%.

❗ Current head 03411f6 differs from pull request most recent head dc5e32a. Consider uploading reports for the commit dc5e32a to get more accurate results

@@            Coverage Diff             @@
##           master    #7918      +/-   ##
==========================================
- Coverage   89.90%   89.35%   -0.56%     
==========================================
  Files         457      457              
  Lines       26835    26857      +22     
==========================================
- Hits        24125    23997     -128     
- Misses       2710     2860     +150     
Files Changed Coverage Δ
torch_geometric/loader/prefetch.py 73.33% <63.63%> (-4.17%) ⬇️
torch_geometric/typing.py 46.10% <80.00%> (-3.28%) ⬇️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

torch_geometric/typing.py Outdated Show resolved Hide resolved
torch_geometric/loader/prefetch.py Outdated Show resolved Hide resolved
torch_geometric/loader/prefetch.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) August 23, 2023 15:31
@rusty1s rusty1s disabled auto-merge August 23, 2023 15:39
@rusty1s rusty1s merged commit f3a1dbd into pyg-team:master Aug 23, 2023
13 of 14 checks passed
JakubPietrakIntel pushed a commit that referenced this pull request Sep 27, 2023
Device abstraction is now covered by an internal class, called
`PrefetchLoaderDevice`. It handles the device selection mechanism,
stream creation, and synchronization.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants