-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable typing support #8254
Enable typing support #8254
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8254 +/- ##
==========================================
- Coverage 88.30% 88.30% -0.01%
==========================================
Files 479 479
Lines 29645 29645
==========================================
- Hits 26178 26177 -1
- Misses 3467 3468 +1 ☔ View full report in Codecov by Sentry. |
866d613
to
1456191
Compare
I'm not very familiar with TorchScript, but it seems like there's an issue with around annotations for TorchScript: pytorch_geometric/torch_geometric/nn/conv/edge_conv.py Lines 116 to 120 in 699120e
https://github.com/pyg-team/pytorch_geometric/actions/runs/7072892589/job/19252222130?pr=8254 I would appreciate any help from the PyG community ❤️ |
Thanks @akihironitta. I fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting out the pre-commit
check for now due to bunch of errors, but I think it is good to get this PR in.
Addresses #3429 (reply in thread).
Related to #5657.
https://peps.python.org/pep-0561/#packaging-type-information