Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subgraph method in case edge_index is not defined #8277

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Fix subgraph method in case edge_index is not defined #8277

merged 2 commits into from
Oct 28, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Oct 28, 2023

Fixes #8272

@rusty1s rusty1s self-assigned this Oct 28, 2023
@rusty1s rusty1s mentioned this pull request Oct 28, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited

Codecov Report

Merging #8277 (b3f6d99) into master (fd2340b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8277   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files         473      473           
  Lines       28635    28639    +4     
=======================================
+ Hits        25033    25039    +6     
+ Misses       3602     3600    -2
Files Coverage Δ
torch_geometric/data/data.py 92.50% <100.00%> (+0.02%) ⬆️
torch_geometric/data/hetero_data.py 89.96% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 67a8b78 into master Oct 28, 2023
16 checks passed
@rusty1s rusty1s deleted the fix_empty_subgraph branch October 28, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@mananshah99 mananshah99 Awaiting requested review from mananshah99 mananshah99 is a code owner

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 bug data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torch_gemoetric.data.Data.subgraph() fails on graph without edges
1 participant
@rusty1s