Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spectral_loss and cluster_loss in DMoNPooling #8285

Merged
merged 24 commits into from
Dec 4, 2023
Merged

Fix spectral_loss and cluster_loss in DMoNPooling #8285

merged 24 commits into from
Dec 4, 2023

Conversation

wwang-chcn
Copy link
Contributor

Fix the issue of spectral_loss and cluster_loss in DMoNPooling mentioned in #8284 (comment).

@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (80989fb) 88.28% compared to head (a3730e9) 88.29%.

❗ Current head a3730e9 differs from pull request most recent head 739860e. Consider uploading reports for the commit 739860e to get more accurate results

Files Patch % Lines
torch_geometric/nn/dense/dmon_pool.py 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8285   +/-   ##
=======================================
  Coverage   88.28%   88.29%           
=======================================
  Files         479      479           
  Lines       29673    29680    +7     
=======================================
+ Hits        26198    26205    +7     
  Misses       3475     3475

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akihironitta akihironitta added the nn label Nov 1, 2023
@rusty1s rusty1s changed the title Fix spectral_loss and cluster_loss in DMoNPooling Fix spectral_loss and cluster_loss in DMoNPooling Nov 2, 2023
@rusty1s rusty1s mentioned this pull request Nov 29, 2023
Closed
@puririshi98
Copy link
Contributor

puririshi98 commented Dec 1, 2023 •
edited

@rusty1s is this good to merge, this PR is blocking internal updates on my end

rusty1s
rusty1s approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting and fixing :)

@rusty1s rusty1s linked an issue Dec 4, 2023 that may be closed by this pull request
Batch Size Dependent Output Values of Spectral Loss and Cluster Loss in torch_geometric.nn.dense.DMoNPooling #8284
Closed
@rusty1s rusty1s enabled auto-merge (squash) December 4, 2023 12:33
@rusty1s rusty1s merged commit bf0419b into pyg-team:master Dec 4, 2023
11 checks passed
@wwang-chcn wwang-chcn deleted the wwang-chcn-dmon-fix branch December 4, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

Assignees

@wwang-chcn wwang-chcn

Labels
0 - Priority P0 bug nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch Size Dependent Output Values of Spectral Loss and Cluster Loss in torch_geometric.nn.dense.DMoNPooling
4 participants
@wwang-chcn @puririshi98 @rusty1s @akihironitta