Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect current device when deep-copying Linear layers #8311

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Nov 1, 2023

Fixes #8305

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #8311 (03b4df0) into master (de6d46d) will decrease coverage by 0.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8311      +/-   ##
==========================================
- Coverage   88.06%   87.38%   -0.69%     
==========================================
  Files         473      473              
  Lines       28675    28671       -4     
==========================================
- Hits        25253    25054     -199     
- Misses       3422     3617     +195     
Files Coverage Δ
torch_geometric/nn/dense/linear.py 90.14% <100.00%> (ø)

... and 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot removed the loader label Nov 1, 2023
@rusty1s rusty1s merged commit f80b0cb into master Nov 1, 2023
16 checks passed
@rusty1s rusty1s deleted the fix_deeepcopy_lin branch November 1, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linear.weight is lazily intialised on CPU after to_hetero leading to device mismatch
1 participant