Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batching issue for HeteroData that is converted using ToSparseTensor when torch_sparse is not installed #8356

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

rachitk
Copy link
Contributor

@rachitk rachitk commented Nov 9, 2023

Fixes #8355.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #8356 (cb80ea8) into master (999af23) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8356   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         473      473           
  Lines       28757    28757           
=======================================
  Hits        25069    25069           
  Misses       3688     3688           
Files Coverage Δ
torch_geometric/data/hetero_data.py 89.96% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusty1s rusty1s merged commit c28d84a into pyg-team:master Nov 10, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect batching with graphs converted by ToSparseTensor()
3 participants