Add support for heterogeneous workloads in multi XPU benchmarks #8382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianSzwichtenberg
force-pushed
the
multi-xpu-hetero
branch
from
5882e4c
to
d2d4585
Compare
JakubPietrakIntel
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
The fix seems valid, but I wonder if there's a way to include this on the GNN-layer level.
@rusty1s don't you think that we should still initialize
x_dst = self.lin_dst(x_dst).view(-1, H, C)
L235C13-L235C59 when there's a self-loop on x_src ?
|
Discussed with @DamianSzwichtenberg. We should update |
A possible solution is available in #8397. |
DamianSzwichtenberg
force-pushed
the
multi-xpu-hetero
branch
from
d2d4585
to
cb5643f
Compare
rusty1s
added a commit
that referenced
this pull request
Nov 19, 2023
This PR fixes the error described in #8382. --------- Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the following error:
HeteroGAT requires additional treatment, as the
lin_dstfrom each of its convolutions is not initialized forpaper-cites-paperrelation (for more details, look at this code).