Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TorchScript support in AttentionalAggregation and DeepSetsAggregation #8406

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fix TorchScript support in AttentionalAggregation and DeepSetsAggregation #8406

merged 3 commits into from
Nov 20, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Nov 20, 2023 •
edited

Fixes #8398

@rusty1s rusty1s self-assigned this Nov 20, 2023
@rusty1s rusty1s mentioned this pull request Nov 20, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ea2ab70) 88.33% compared to head (da6ffd6) 87.69%.
Report is 1 commits behind head on master.

Files Patch % Lines
torch_geometric/nn/aggr/deep_sets.py 78.94% 4 Missing ⚠️
torch_geometric/nn/aggr/attention.py 88.23% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8406      +/-   ##
==========================================
- Coverage   88.33%   87.69%   -0.64%     
==========================================
  Files         475      475              
  Lines       28920    28934      +14     
==========================================
- Hits        25547    25375     -172     
- Misses       3373     3559     +186

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s enabled auto-merge (squash) November 20, 2023 07:51
@rusty1s rusty1s merged commit 362fe90 into master Nov 20, 2023
16 checks passed
@rusty1s rusty1s deleted the fix_script_attention_aggr branch November 20, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 bug nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TorchScript attentional aggregation error
1 participant
@rusty1s