-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge TemporalData
with Data
/HeteroData
[1/n]
#8454
Merged
rusty1s
merged 13 commits into
pyg-team:master
from
DamianSzwichtenberg:merge-temporal-and-data
Dec 10, 2023
Merged
Merge TemporalData
with Data
/HeteroData
[1/n]
#8454
rusty1s
merged 13 commits into
pyg-team:master
from
DamianSzwichtenberg:merge-temporal-and-data
Dec 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
rusty1s
reviewed
Nov 28, 2023
DamianSzwichtenberg
force-pushed
the
merge-temporal-and-data
branch
from
November 29, 2023 11:47
b921dae
to
871bc73
Compare
DamianSzwichtenberg
changed the title
Merge
Merge Nov 29, 2023
TemporalData
with Data
TemporalData
with Data
/HeteroData
[1/n]
DamianSzwichtenberg
requested review from
wsad1 and
mananshah99
as code owners
November 29, 2023 12:16
EdisonLeeeee
reviewed
Dec 5, 2023
DamianSzwichtenberg
force-pushed
the
merge-temporal-and-data
branch
from
December 8, 2023 12:55
2664f99
to
c17b155
Compare
DamianSzwichtenberg
force-pushed
the
merge-temporal-and-data
branch
from
December 8, 2023 12:59
c17b155
to
08b5b41
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8454 +/- ##
==========================================
+ Coverage 88.76% 88.77% +0.01%
==========================================
Files 479 479
Lines 29955 30034 +79
==========================================
+ Hits 26589 26664 +75
- Misses 3366 3370 +4 ☔ View full report in Codecov by Sentry. |
rusty1s
approved these changes
Dec 10, 2023
…erg/pytorch_geometric into merge-temporal-and-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to merge TemporalData into Data.
Currently, only edge events are supported. For
(src, dst)
event definitionedge_index
is reused as its definition is aligned with our needs. Formsg
,edge_attr
is reused. An additional attribute istime
, which represents an event's occurrence time.New methods include the following:
is_sorted_by_time()
: returnsTrue
if data is sorted according totime
,False
otherwise.sort_by_time()
: sorts event data according totime
.snapshot(start_time, end_time)
: returns event data that occurred in range<start_time, end_time>
.up_to(time)
: returns event data that occurred before or at a giventime
.concat(data)
: returns new data that concatenates the object on which the method was called and givendata
. Can be used to add new events.Related issue: #3230