Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN handling in SQLDatabase #8479

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix NaN handling in SQLDatabase #8479

merged 2 commits into from
Nov 29, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Nov 29, 2023

Fixes #8473

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29db6ae) 87.71% compared to head (a72fa76) 87.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8479   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files         478      478           
  Lines       29368    29370    +2     
=======================================
+ Hits        25761    25763    +2     
  Misses       3607     3607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 408d23e into master Nov 29, 2023
16 checks passed
@rusty1s rusty1s deleted the fix_nan_handling branch November 29, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnDiskDataset for PCQNM4v2 is broken
1 participant