Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed node-level and edge-level temporal sampling for hetero #8624

Merged
merged 7 commits into from
Dec 30, 2023

Conversation

kgajdamo
Copy link
Contributor

The purpose of this PR is to enable distributed sampling with node-level and edge-level temporal information for heterogeneous graphs.

Description:

  • Heterogeneous temporal sampling is analogous to homogeneous temporal sampling, but takes into account the presence of node types and edge types. We define the node time information for each node type and the edge time information for each edge type.
  • Because of the lack of the node_store/edge_store in the feature store we determine whether to use node-level or edge-level temporal sampling based on the time_attr value ('time' or 'edge_time').
  • seed_time is mandatory for edge-level sampling.
  • seed_time field has been added to the NodeDict class to store the time information of the source nodes.
  • The time information of source nodes for the next layer is calculated based on the subgraph ID a given node belongs to (each subgraph has a seed time specified, which is common for all source nodes).

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d1f305b) 89.49% compared to head (215a0d9) 89.50%.

❗ Current head 215a0d9 differs from pull request most recent head 1ad465a. Consider uploading reports for the commit 1ad465a to get more accurate results

Files Patch % Lines
torch_geometric/sampler/neighbor_sampler.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8624      +/-   ##
==========================================
+ Coverage   89.49%   89.50%   +0.01%     
==========================================
  Files         481      481              
  Lines       31084    31096      +12     
==========================================
+ Hits        27819    27833      +14     
+ Misses       3265     3263       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgajdamo kgajdamo force-pushed the dist-hetero-temporal branch 4 times, most recently from 5261620 to af46c11 Compare December 21, 2023 09:12
@rusty1s rusty1s enabled auto-merge (squash) December 30, 2023 19:21
@rusty1s rusty1s merged commit 1b3112f into pyg-team:master Dec 30, 2023
12 checks passed
@kgajdamo kgajdamo deleted the dist-hetero-temporal branch January 5, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants