Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all synthetic data referenced in GNNExplainer #8736

Merged
merged 8 commits into from
Jan 7, 2024

Conversation

Sutongtong233
Copy link
Contributor

@Sutongtong233 Sutongtong233 commented Jan 7, 2024

A smaller PR for #8704

Include grid motifs and tree-based datasets in GNNExplainer.

  • add torch_geometric/datasets/graph_generator/tree_graph.py
  • add torch_geometric/datasets/motif_generator/grid.py
  • add node label in torch_geometric/datasets/motif_generator/cycle.py (according to bug report CycleMotif lack of label, therefore do not support GNNExplainer. #8509, it is better to directly add node label since we know what the label should be, rather than be captured at else sentense in line 127 of ./torch_geometric/datasets/explainer_dataset.py)

pre-commit-ci bot and others added 2 commits January 7, 2024 17:52
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fb6ff1) 89.56% compared to head (c9a0d15) 89.57%.

❗ Current head c9a0d15 differs from pull request most recent head c05c214. Consider uploading reports for the commit c05c214 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8736   +/-   ##
=======================================
  Coverage   89.56%   89.57%           
=======================================
  Files         481      481           
  Lines       31048    31048           
=======================================
+ Hits        27809    27810    +1     
+ Misses       3239     3238    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s changed the title Include all synthetic data referenced in GNNExplainer Include all synthetic data referenced in GNNExplainer Jan 7, 2024
@rusty1s rusty1s enabled auto-merge (squash) January 7, 2024 23:19
@rusty1s rusty1s merged commit 5230418 into pyg-team:master Jan 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants